RequestHandler refactor, remove response from handler#4664
Merged
auto-submit[bot] merged 5 commits intoMay 9, 2025
Conversation
matanlurey
changed the title
RequestHandler refactors, take XRequestHandler refactor, remove response from handler
jtmcdole
approved these changes
May 9, 2025
| /// | ||
| /// Returns a future that completes when [response] has been closed. | ||
| Future<void> _respond(HttpResponse response, Body body) async { | ||
| Future<void> _respond(HttpResponse response, Response body) async { |
Member
There was a problem hiding this comment.
HttpResponse vs Response isn't confusing at all 😄
matanlurey
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
BodytoResponse, encapsulating everything it did before.