In markConclusion do not throw exception if remainingJobs is zero#5113
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the UnifiedCheckRun class to gracefully handle cases where the remaining jobs count is already zero by logging the occurrence instead of throwing an exception, and adds a corresponding unit test. The reviewer identified a critical runtime issue where log.error is called on a Dart Logger instance, which does not exist and will throw a NoSuchMethodError at runtime; they recommended using log.warning or log.severe instead.
jtmcdole
approved these changes
Jul 24, 2026
ievdokdm
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
markConclusiondo not throw exception if remainingJobs is zero but keep it zerofix: flutter/flutter#189989