Skip to content

Adding aditional logging for debugging - #5119

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
ievdokdm:logging
Aug 3, 2026
Merged

Adding aditional logging for debugging#5119
auto-submit[bot] merged 1 commit into
flutter:mainfrom
ievdokdm:logging

Conversation

@ievdokdm

@ievdokdm ievdokdm commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

logging for debugging behavior of #5117

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 3, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a log statement in luci_build_service.dart when re-requesting dashboard checks for a PresubmitGuard. The review feedback correctly points out that interpolating the guard object directly will result in a generic string representation, and suggests printing guard.name instead for better debugging.

Comment thread app_dart/lib/src/service/luci_build_service.dart
@ievdokdm
ievdokdm requested a review from jtmcdole August 3, 2026 21:13
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App. label Aug 3, 2026
@auto-submit
auto-submit Bot merged commit a490529 into flutter:main Aug 3, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants