-
Notifications
You must be signed in to change notification settings - Fork 390
ErrorBadgeManager rewrite to separate inspector specific logic #9105
Copy link
Copy link
Open
Labels
P2important to work on, but not at the top of the work list.important to work on, but not at the top of the work list.contributions welcomeActively welcoming contributions for these high-priority issues.Actively welcoming contributions for these high-priority issues.cross-screenIssues that affect multiple DevTools screens, i.e. shared functionality and widgetsIssues that affect multiple DevTools screens, i.e. shared functionality and widgetstech debt
Metadata
Metadata
Assignees
Labels
P2important to work on, but not at the top of the work list.important to work on, but not at the top of the work list.contributions welcomeActively welcoming contributions for these high-priority issues.Actively welcoming contributions for these high-priority issues.cross-screenIssues that affect multiple DevTools screens, i.e. shared functionality and widgetsIssues that affect multiple DevTools screens, i.e. shared functionality and widgetstech debt
ErrorBadgeManagerhas a lot of conditional logic for inspector errors (e.g.,appendErroronly works for inspector errors because we are only saving inspector errors in the `activeErrors map:devtools/packages/devtools_app/lib/src/shared/managers/error_badge_manager.dart
Lines 32 to 37 in 36ac0a2
This file and logic could use an overhaul to move the Inspector specific logic to the Inspector controller.