Skip to content

ErrorBadgeManager rewrite to separate inspector specific logic #9105

@elliette

Description

@elliette

ErrorBadgeManager has a lot of conditional logic for inspector errors (e.g., appendError only works for inspector errors because we are only saving inspector errors in the `activeErrors map:

final _activeErrors =
<String, ValueNotifier<LinkedHashMap<String, DevToolsError>>>{
InspectorScreen.id: ValueNotifier<LinkedHashMap<String, DevToolsError>>(
LinkedHashMap<String, DevToolsError>(),
),
};
)

This file and logic could use an overhaul to move the Inspector specific logic to the Inspector controller.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2important to work on, but not at the top of the work list.contributions welcomeActively welcoming contributions for these high-priority issues.cross-screenIssues that affect multiple DevTools screens, i.e. shared functionality and widgetstech debt

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions