Add json prettyprinting detail view to the log details page.#1375
Add json prettyprinting detail view to the log details page.#1375DaveShuckerow merged 5 commits intoflutter:masterfrom
Conversation
Cross-fade between log details views
DaveShuckerow
force-pushed
the
logging-details
branch
from
614e678 to
aff9dad
Compare
| super.initState(); | ||
| crossFade = AnimationController( | ||
| vsync: this, | ||
| duration: const Duration(milliseconds: 200), |
There was a problem hiding this comment.
we should soon do an audit of all durations used and add some top level duration constants used throughout the app.
| Future<String> detailsComputer; | ||
| Future<String> Function() detailsComputer; | ||
|
|
||
| static const JsonEncoder prettyPrinter = JsonEncoder.withIndent(' '); |
There was a problem hiding this comment.
why indent 4? use indent 2 and a fixed sized font instead. There is some similar code in the json display in the timeline.
There was a problem hiding this comment.
We don't have any monospaced fonts bundled yet. I've left a TODO.
| Expanded( | ||
| child: LogsTable( | ||
| data: controller.data, | ||
| child: Split( |
There was a problem hiding this comment.
do we not think expandable table children are practical? showing a separate details view in the existing logging page was more for expediency than by design. I'd hope we can do better in Flutter and actually show the details inline.
There was a problem hiding this comment.
It is doable, just out of scope for this PR, as discussed offline.
|
|
DaveShuckerow
force-pushed
the
logging-details
branch
from
09f18b8 to
ec3b6a9
Compare
2 participants
Also adds in a crossfade animation between log details views.
I'm going to punt on the error inspector for a few weeks to prepare for demos.