[Story of Your Layout] Visualize main axis spaces#1378
Merged
albertusdev merged 5 commits intoflutter:masterfrom Nov 23, 2019
Merged
[Story of Your Layout] Visualize main axis spaces#1378albertusdev merged 5 commits intoflutter:masterfrom
albertusdev merged 5 commits intoflutter:masterfrom
Conversation
jacob314
reviewed
Nov 21, 2019
packages/devtools_app/lib/src/inspector/flutter/inspector_data_models.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Nov 21, 2019
| } | ||
| } | ||
|
|
||
| double computeSpaceAfterChildren({ |
Contributor
There was a problem hiding this comment.
Add a helper method that does the logic for all cases but start, and end and call it from both these helpers.
You could call the helper
_computeSpaceBetweenChildren
and have it assert if MainAxisAlignment is start or end.
Contributor
There was a problem hiding this comment.
or maybe _computeSpaceHelper
jacob314
reviewed
Nov 21, 2019
packages/devtools_app/lib/src/inspector/flutter/inspector_data_models.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Nov 21, 2019
packages/devtools_app/lib/src/inspector/flutter/story_of_your_layout/flex.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Nov 21, 2019
packages/devtools_app/lib/src/inspector/inspector_controller.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Nov 21, 2019
Contributor
jacob314
left a comment
jacob314
left a comment
There was a problem hiding this comment.
with some minor comments
albertusdev
force-pushed
the
story-of-layout-visualize-main-axis-spaces
branch
from
624ca5e to
eb5b159
Compare
albertusdev
changed the title
added 2 commits
November 22, 2019 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelist:
TODOs:
Demo:
https://www.youtube.com/watch?v=dcf9tC2iaB8&feature=youtu.be