Skip to content

[Story of Your Layout] Make dropdown align to their axis and make flex widget clickable#1392

Merged
albertusdev merged 6 commits into
flutter:masterfrom
albertusdev:story-of-layout-dropdown-tweaks
Nov 22, 2019
Merged

[Story of Your Layout] Make dropdown align to their axis and make flex widget clickable#1392
albertusdev merged 6 commits into
flutter:masterfrom
albertusdev:story-of-layout-dropdown-tweaks

Conversation

@albertusdev
Copy link
Copy Markdown
Contributor

TODOs:

  • Test will fail, will update the goldens in the Linux machine tomorrow

Changelist

  • Refactor LayoutProperties to depend on RemoteDiagnosticsNode instead of InspectorTreeNode
  • Align dropdown button to their respective axis to save more space
  • Make vertical dropdown smart
  • Make flex widget clickable

Demo

Dark mode

https://youtu.be/ychMMhjinIo

Light mode

TODO

@albertusdev albertusdev requested a review from jacob314 November 22, 2019 10:15
Comment thread packages/devtools_app/lib/src/inspector/flutter/story_of_your_layout/flex.dart Outdated
Copy link
Copy Markdown
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@albertusdev albertusdev changed the title [WIP][Story of Your Layout] Make dropdown align to their axis and make flex widget clickable [Story of Your Layout] Make dropdown align to their axis and make flex widget clickable Nov 22, 2019
@albertusdev albertusdev merged commit fd433ca into flutter:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants