Automatically reset the test size between tests.#1399
Merged
DaveShuckerow merged 5 commits intoflutter:masterfrom Nov 25, 2019
Merged
Automatically reset the test size between tests.#1399DaveShuckerow merged 5 commits intoflutter:masterfrom
DaveShuckerow merged 5 commits intoflutter:masterfrom
Conversation
kenzieschmoll
approved these changes
Nov 25, 2019
| Future<void> setWindowSize(Size windowSize) async { | ||
| /// Runs a test with the size of the app window under test to [windowSize]. | ||
| @isTest | ||
| void testWidgetsWithSize( |
Member
There was a problem hiding this comment.
nit: rename to testWidgetsWithWindowSize as withSize makes it seem like size is referring to the widget, not the window
| @isTest | ||
| void testWidgetsWithSize( | ||
| String name, Size windowSize, WidgetTesterCallback test, | ||
| {bool skip = false}) { |
added 2 commits
November 25, 2019 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of tests weren't calling
resetWindowSizeat the end of the test, which I believe was leading to the overridden window size propagating across tests.