Skip to content

Enable layout explorer feature #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Enable layout explorer feature #1472

wants to merge 2 commits into from

Conversation

@DaveShuckerow
Copy link
Contributor

@DaveShuckerow DaveShuckerow commented Dec 10, 2019

@kenzieschmoll
Copy link
Member

kenzieschmoll commented Dec 10, 2019

This change will also need to be reverted for the feature to be enabled in web #1459

@DaveShuckerow DaveShuckerow marked this pull request as ready for review December 10, 2019 19:08
@DaveShuckerow
Copy link
Contributor Author

DaveShuckerow commented Dec 10, 2019

This change will also need to be reverted for the feature to be enabled in web #1459

Thanks, revert commit added.

albertusdev
albertusdev suggested changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@albertusdev albertusdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 4eecf6e is landed, this experimental flag has nothing to do with the Layout Explorer feature at all but this is used for enabling the Show Constraints button that enables rendering constraint next to the Inspector Tree.
I think I should remove that part of code since it is unused, I will send the PR for that one.
So the only required commit for this PR is just to revert @kenzieschmoll's commit

albertusdev
albertusdev reviewed Dec 10, 2019
View reviewed changes
packages/devtools_app/lib/src/inspector/inspector_controller.dart

// TODO(albertusangga): Remove this flag if required CL to Flutter is landed
static bool enableExperimentalStoryOfLayout = false;
static bool enableExperimentalStoryOfLayout = true;
Copy link
Contributor

@albertusdev albertusdev Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for this one, I should have removed it completely, this is unnecessary to enable the layout explorer

@albertusdev
Copy link
Contributor

albertusdev commented Dec 10, 2019

Closing in favor of #1475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

+1 more reviewer

@albertusdev albertusdev albertusdev requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DaveShuckerow @kenzieschmoll @albertusdev