Skip to content

Enable layout explorer feature #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Enable layout explorer feature #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc120f8
Enable layout explorer feature
Dec 10, 2019
cd28465
Revert #1459
Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/devtools_app/lib/src/inspector/flutter/inspector_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:vm_service/vm_service.dart' hide Stack;

Expand Down Expand Up @@ -242,7 +241,7 @@ class _InspectorScreenBodyState extends State<InspectorScreenBody>
inspectorService: inspectorService,
treeType: FlutterTreeType.widget,
onExpandCollapseSupported: _onExpandCollapseSupported,
onLayoutExplorerSupported: kIsWeb ? null : _onLayoutExplorerSupported,
onLayoutExplorerSupported: _onLayoutExplorerSupported,
);

// TODO(jacobr): move this notice display to once a day.
Expand Down
3 changes: 1 addition & 2 deletions packages/devtools_app/lib/src/inspector/inspector_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,7 @@ class InspectorController extends DisposableController
debugSummaryLayoutEnabled.value = !debugSummaryLayoutEnabled.value;
}

// TODO(albertusangga): Remove this flag if required CL to Flutter is landed
static bool enableExperimentalStoryOfLayout = false;
static bool enableExperimentalStoryOfLayout = true;
Copy link
Contributor

@albertusdev albertusdev Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry for this one, I should have removed it completely, this is unnecessary to enable the layout explorer


final List<VoidCallback> _selectionListeners = [];

Expand Down