Protect against NPE caused by null devtoolsServer#1940
Merged
Conversation
devoncarew
approved these changes
May 7, 2020
devoncarew
left a comment
Contributor
There was a problem hiding this comment.
lgtm
I believe that devToolsServer will be null if devtools was not launched from the server. If that's not the case here, we may have a race condition.
Contributor
|
I think previously the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@DanTup we were seeing exceptions in g3 because
devToolsServerwas null ("devtools server not available (204)" printed to console in this case).This will fix the NPE but do we expect `devToolsServer to be null?