remove the animation for appbar layout changes#2024
Merged
Conversation
kenzieschmoll
approved these changes
Jun 1, 2020
Member
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
LGTM with a couple nits
|
|
||
| AnimationController appBarAnimation; | ||
| CurvedAnimation appBarCurve; | ||
| static const Object _appBarTag = 'DevTools AppBar'; |
Member
There was a problem hiding this comment.
why did this change from String to Object
Contributor
Author
There was a problem hiding this comment.
It's used as an Object later on, so I just updated the type to reflect the intend.
| preferredSize = isNarrow | ||
| ? const Size.fromHeight(kToolbarHeight + 40.0) | ||
| : const Size.fromHeight(kToolbarHeight); | ||
| final animatedAlignment = |
Member
There was a problem hiding this comment.
rename to alignment since it is no longer animated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the memory page would deadlock when running on Flutter desktop. Because of where the animation was defined in the widget hierarchy, it would cause the app screens to rebuild often. There may still be a deadlock in the memory page, but if so we no longer seem to hit it.
Most pages only rebuild once now when switching screens. The memory page may rebuild twice (from brief observation). And - not topical for this PR - it seems to take about 300-400ms to build the frame when switching into the Inspector page; that all seems to be spent in layout.