Skip to content

remove the date from network timestamps #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 2 commits into from
Jun 5, 2020
Merged

remove the date from network timestamps #2040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e957e6
remove the date from network timestamps
devoncarew Jun 4, 2020
b3c3da8
remove the date from network timestamps
devoncarew Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/devtools_app/lib/src/network/flutter/network_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ class DurationColumn extends ColumnData<HttpRequestData> {

class TimestampColumn extends ColumnData<HttpRequestData> {
TimestampColumn()
: super('Timestamp', alignment: ColumnAlignment.right, fixedWidthPx: 165);
: super('Timestamp', alignment: ColumnAlignment.right, fixedWidthPx: 135);

@override
dynamic getValue(HttpRequestData dataObject) {
Expand All @@ -315,6 +315,6 @@ class TimestampColumn extends ColumnData<HttpRequestData> {

@visibleForTesting
static String formatRequestTime(DateTime requestTime) {
return DateFormat.Hms().add_yMd().format(requestTime);
return DateFormat('h:mm:ss.S a').format(requestTime);
}
}
8 changes: 3 additions & 5 deletions packages/devtools_app/test/flutter/network_model_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,10 @@ void main() {

// The hours field may be unreliable since it depends on the timezone the
// test is running in.
expect(column.getDisplayValue(request), contains(':25:34 1/3/1970'));
expect(column.getDisplayValue(request), contains(':25:34.126'));

expect(
TimestampColumn.formatRequestTime(DateTime(2020, 1, 16, 13)),
'13:00:00 1/16/2020',
);
expect(TimestampColumn.formatRequestTime(DateTime(2020, 1, 16, 13)),
'1:00:00.000 PM');
});
});
}