Skip to content

update inspector goldens #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 2 commits into from
Apr 19, 2021
Merged

update inspector goldens #2919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e77eecc
update inspector goldens
kenzieschmoll Apr 19, 2021
53301a7
formatting
kenzieschmoll Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/devtools_app/lib/src/app.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,8 @@ class DevToolsAppState extends State<DevToolsApp> {

Widget _providedControllers({@required Widget child, bool offline = false}) {
final _providers = widget.screens
.where((s) =>
s.providesController && (offline ? s.supportsOffline : true))
.where(
(s) => s.providesController && (offline ? s.supportsOffline : true))
.map((s) => s.controllerProvider)
.toList();

Expand Down Expand Up @@ -581,9 +581,7 @@ List<DevToolsScreen> get defaultScreens {
createController: () => AppSizeController(),
),
DevToolsScreen<VMDeveloperToolsController>(
VMDeveloperToolsScreen(
controller: vmDeveloperToolsController
),
VMDeveloperToolsScreen(controller: vmDeveloperToolsController),
controller: vmDeveloperToolsController,
),
// Uncomment to see a sample implementation of a conditional screen.
Expand Down
16 changes: 8 additions & 8 deletions packages/devtools_app/lib/src/memory/memory_heap_tree_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,12 +393,12 @@ class HeapTreeViewState extends State<HeapTree>
_isSnapshotStreaming
? 'Processing...'
: _isSnapshotGraphing
? 'Graphing...'
: _isSnapshotGrouping
? 'Grouping...'
: _isSnapshotComplete
? 'Done'
: '...',
? 'Graphing...'
: _isSnapshotGrouping
? 'Grouping...'
: _isSnapshotComplete
? 'Done'
: '...',
),
],
);
Expand Down Expand Up @@ -479,8 +479,8 @@ class HeapTreeViewState extends State<HeapTree>
final rightSideTable = controller.isLeafSelected
? InstanceTreeView()
: controller.isAnalysisLeafSelected
? Expanded(child: AnalysisInstanceViewTable())
: helpScreen();
? Expanded(child: AnalysisInstanceViewTable())
: helpScreen();

return treeMapVisible
? snapshotDisplay
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_app/lib/src/vm_developer/vm_developer_tools_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ class VMDeveloperToolsScreenBody extends StatefulWidget {

class _VMDeveloperToolsScreenState extends State<VMDeveloperToolsScreenBody>
with AutoDisposeMixin {

VMDeveloperToolsController controller;

@override
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_testing/goldens/inspector_service_details_tree.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ MaterialApp
│ state: _MaterialAppState#00000
│
└─ScrollConfiguration
│ behavior: _MaterialScrollBehavior
│ behavior: MaterialScrollBehavior
│
└─HeroControllerScope
└─WidgetsApp-[GlobalObjectKey _MaterialAppState#00000]
Expand Down