Skip to content

Display top frame initially for Dart web #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grouma merged 4 commits into from
Apr 27, 2021
Merged

Display top frame initially for Dart web #2946

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9799ffa
Display top frame initially for Dart web
grouma Apr 27, 2021
453d3a3
remove true clause
grouma Apr 27, 2021
ae2ff70
Merge branch 'master' into stack
grouma Apr 27, 2021
b56943d
trailing
grouma Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/devtools_app/lib/src/debugger/debugger_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,20 @@ class DebuggerController extends DisposableController
return;
}

// Collecting frames for Dart web applications can be slow. At the potential
// cost of a flicker in the stack view, display only the top frame
// initially.
if (await serviceManager.connectedApp.isDartWebApp) {
_populateFrameInfo(
[
await _createStackFrameWithLocation(pauseEvent.topFrame),
],
truncated: true,
);
unawaited(_getFullStack());
return;
}

// We populate the first 12 frames; this ~roughly corresponds to the number
// of visible stack frames.
const initialFrameRequestCount = 12;
Expand Down