Skip to content

Profiler ellipsis and alignment fix #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CoderDake merged 1 commit into from
Jun 6, 2022
+14 −6
Merged

Profiler ellipsis and alignment fix #4166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/devtools_app/lib/src/screens/profiler/cpu_profile_columns.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,17 +79,11 @@ class TotalTimeColumn extends ColumnData<CpuStackFrame> {

class MethodNameColumn extends TreeColumnData<CpuStackFrame> {
MethodNameColumn() : super('Method');

static const maxMethodNameLength = 75;

@override
dynamic getValue(CpuStackFrame dataObject) => dataObject.name;

@override
String getDisplayValue(CpuStackFrame dataObject) {
if (dataObject.name.length > maxMethodNameLength) {
return dataObject.name.substring(0, maxMethodNameLength) + '...';
}
return dataObject.name;
}

Expand Down
1 change: 1 addition & 0 deletions packages/devtools_app/lib/src/service/resolved_uri_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ class ResolvedUriManager {
/// [isolateId] The id of the isolate that the [uris] were generated on.
/// [uris] List of uris to fetch package uris for.
Future<void> fetchPackageUris(String isolateId, List<String> uris) async {
if (uris.isEmpty) return;
if (_packagePathMappings != null) {
final packageUris =
(await serviceManager.service!.lookupPackageUris(isolateId, uris))
Expand Down
13 changes: 13 additions & 0 deletions packages/devtools_app/lib/src/shared/table.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,6 +1302,18 @@ class _TableRowState<T> extends State<TableRow<T>>
}
}

TextAlign _textAlignmentFor(ColumnData<T> column) {
switch (column.alignment) {
case ColumnAlignment.center:
return TextAlign.center;
case ColumnAlignment.right:
return TextAlign.right;
case ColumnAlignment.left:
default:
return TextAlign.left;
}
}

MainAxisAlignment _mainAxisAlignmentFor(ColumnData<T> column) {
switch (column.alignment) {
case ColumnAlignment.center:
Expand Down Expand Up @@ -1379,6 +1391,7 @@ class _TableRowState<T> extends State<TableRow<T>>
overflow: TextOverflow.ellipsis,
style: contentTextStyle(column),
maxLines: 1,
textAlign: _textAlignmentFor(column),
);
}

Expand Down