Skip to content

Pitch snapshot diffing. #5544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polina-c merged 3 commits into from
Mar 29, 2023
+4 −0
Merged

Pitch snapshot diffing. #5544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a25a14
Update diff_pane.dart
polina-c Mar 28, 2023
2aee182
-
polina-c Mar 29, 2023
7b3493f
Merge branch 'master' of github.com:flutter/devtools into sales
polina-c Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/devtools_app/lib/src/screens/memory/panes/diff/diff_pane.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@ class SnapshotInstanceItemPane extends StatelessWidget {

/// `\v` adds vertical space
const _snapshotDocumentation = '''
Find unexpected memory usage by comparing two heap snapshots:
Copy link
Contributor

@bkonyi bkonyi Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe "Examine changes in memory usage by comparing two heap snapshots:"? Or "Debug changes in memory usage..."?

Copy link
Contributor Author

@polina-c polina-c Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrasing was suggested by Tao. I like it more than your suggestions because it emphasizes that diffing will help to find something unexpected.
People are not interested to see expected changes. They are interested to find if there is unexpected usage. Not necessary because of change. Some people never checked memory usage before.


\v

1. Understand [Dart memory concepts](https://docs.flutter.dev/development/tools/devtools/memory#basic-memory-concepts).

\v
Expand Down
Binary file modified packages/devtools_app/test/test_infra/goldens/memory_diff_empty1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/devtools_app/test/test_infra/goldens/memory_diff_empty2.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.