Re-land SDK detection changes with support for running from PATH #6824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e FLUTTER_ROOT (flutter#6776)" (flutter#6820)" This reverts commit 79cde66.
kenzieschmoll
approved these changes
Nov 29, 2023
Contributor
Author
|
I just realised the green status here was probably stale from before master broke. Let me know if I should revert this while you're fixing the build or not. |
DanTup
added a commit
to flutter/tests
that referenced
this pull request
Nov 30, 2023
This updates the DevTools to the current latest hash from https://github.com/flutter/devtools/commits/master. It includes flutter/devtools#6824 which relands some changes to help users always use DevTools pinned version of Flutter, but now in a way that allows this script to still use its own (head) version of Flutter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit (f21229b) here is a straight re-land of #6776 (a revert of the revert at #6820 / 79cde66).
The second commit (a5103ad) adds an env variable you can set to force devtools_tool to use Dart/Flutter from
PATHrather than the one from tool/flutter-sdk, and sets it in the flutter_customer_tests script.I made this explicit so it's difficult to do accidentally, because I think outside of the Flutter customer tests, we do generally want everything to use the pinned version.
@kenzieschmoll