Trim mixins from CPU stack frame names. #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Jun 4, 2019
Contributor
devoncarew
left a comment
devoncarew
left a comment
There was a problem hiding this comment.
lgtm
I think we'll have the same issue in the debugger UI w/ stack frames. Can you open an issue for that, and reference this PR for context?
| } | ||
|
|
||
| /// Whether a given code unit is a letter (A-Z or a-z). | ||
| bool isLetter(int codeUnit) => |
Contributor
There was a problem hiding this comment.
I'm not sure if there's anything we can leverage in Dart or the core libraries here? cc @scheglov
Member
Author
|
Done ☝️ |
Contributor
|
There are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
_WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallbackThe important information here would be
_WidgetsFlutterBinding._handlePersistentFrameCallback, which is now what we will show in the profiler UI.Original issue filed here: dart-lang/sdk#36999. Handling the name processing locally.