[Inspector V2] RichText widgets show up in inspector tree#8115
Merged
elliette merged 6 commits intoflutter:masterfrom Jul 31, 2024
Merged
[Inspector V2] RichText widgets show up in inspector tree#8115elliette merged 6 commits intoflutter:masterfrom
elliette merged 6 commits intoflutter:masterfrom
Conversation
Member
Author
|
Not yet ready for review, converting to draft PR. |
packages/devtools_app/lib/src/shared/diagnostics/diagnostics_node.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/shared/diagnostics/diagnostics_node.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/shared/diagnostics/diagnostics_node.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8103
I noticed that the widget tree didn't contain any
RichTextwidgets. This is because there was a flaw in the logic determining whether an implementation widget should be in a hidden group. We weren't handling the following two cases:RichText), e.g.: