Skip to content

[Inspector V2] RichText widgets show up in inspector tree#8115

Merged
elliette merged 6 commits intoflutter:masterfrom
elliette:issue-8103
Jul 31, 2024
Merged

[Inspector V2] RichText widgets show up in inspector tree#8115
elliette merged 6 commits intoflutter:masterfrom
elliette:issue-8103

Conversation

@elliette
Copy link
Copy Markdown
Member

Fixes #8103

Screenshot 2024-07-29 at 5 16 06 PM

I noticed that the widget tree didn't contain any RichText widgets. This is because there was a flaw in the logic determining whether an implementation widget should be in a hidden group. We weren't handling the following two cases:

  1. The implementation widget is "sandwiched" between two visible widgets, e.g.
Project Widget A
            |
Implementation Widget B
            |
Project Widget C
  1. The implementation widget is the child of a visible widget, and has no children itself (like RichText), e.g.:
Project Widget A
            |
Implementation Widget B

@elliette elliette requested a review from a team as a code owner July 30, 2024 00:23
@elliette elliette requested review from kenzieschmoll and removed request for a team July 30, 2024 00:23
@elliette elliette marked this pull request as draft July 30, 2024 16:04
@elliette elliette requested review from a team and kenzieschmoll and removed request for a team and kenzieschmoll July 30, 2024 16:04
@elliette
Copy link
Copy Markdown
Member Author

Not yet ready for review, converting to draft PR.

@elliette elliette marked this pull request as ready for review July 30, 2024 18:16
@elliette elliette merged commit 4e8ecdb into flutter:master Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Inspector V2] RichText is hidden from the widget tree

2 participants