Skip to content

Turn off the disconnect support for the memory screen #8128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 5 commits into from
Aug 1, 2024
Merged

Turn off the disconnect support for the memory screen #8128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c417945
Turn off the disconnect support for the memory screen
kenzieschmoll Jul 31, 2024
a0bdbcb
rnotes
kenzieschmoll Jul 31, 2024
93f7835
formatting and fix lint
kenzieschmoll Jul 31, 2024
9d083c8
fix visible screens test
kenzieschmoll Jul 31, 2024
184c3a6
delete test
kenzieschmoll Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions packages/devtools_app/integration_test/test/offline/memory_offline_data_test.dart
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/shared/feature_flags.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void setEnableExperiments() {
bool get enableBeta => enableExperiments || !isExternalBuild;

const _kMemoryOfflineExperiment =
bool.fromEnvironment('memory_offline_experiment', defaultValue: true);
bool.fromEnvironment('memory_offline_experiment');

// It is ok to have enum-like static only classes.
// ignore: avoid_classes_with_only_static_members
Expand Down
4 changes: 1 addition & 3 deletions packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ TODO: Remove this section if there are not any general updates.

## Memory updates

* Enable offline analysis of snapshots, historical data analysis and save/load. - [#7843](https://github.com/flutter/devtools/pull/7843)

![Memory offline data](images/memory-save-load.png "Memory offline data")
TODO: Remove this section if there are not any general updates.

## Debugger updates

Expand Down
Binary file removed packages/devtools_app/release_notes/images/memory-save-load.png
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/devtools_app/test/shared/visible_screens_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ void main() {
// InspectorScreen,
PerformanceScreen, // Works offline, so appears regardless of web flag
ProfilerScreen, // Works offline, so appears regardless of web flag
MemoryScreen,
// MemoryScreen,
// DebuggerScreen,
// NetworkScreen,
// LoggingScreen,
Expand Down
Loading