Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/devtools_app/lib/src/app.dart
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
BuildContext _,
String? page,
DevToolsQueryParams queryParams,
DevToolsNavigationState? __,
DevToolsNavigationState? _,
) {
final vmServiceUri = queryParams.vmServiceUri;
final embedMode = queryParams.embedMode;
Expand All @@ -262,7 +262,7 @@ class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
preferences.vmDeveloperModeEnabled,
extensionService.currentExtensions,
],
builder: (_, __, child) {
builder: (_, _, child) {
final screensInScaffold = _visibleScreens()
.where(
(s) => maybeIncludeOnlyEmbeddedScreen(
Expand Down Expand Up @@ -359,7 +359,7 @@ class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
return _routes ??= {
homeScreenId: _buildTabbedPage,
for (final screen in _screens) screen.screenId: _buildTabbedPage,
snapshotScreenId: (_, __, params, ___) {
snapshotScreenId: (_, _, params, _) {
return DevToolsScaffold.withChild(
key: UniqueKey(),
embedMode: params.embedMode,
Expand All @@ -386,7 +386,7 @@ class DevToolsAppState extends State<DevToolsApp> with AutoDisposeMixin {
// the server which page they are rendering.
return {
for (final type in StandaloneScreenType.values)
type.name: (_, __, args, ___) => type.screen,
type.name: (_, _, args, _) => type.screen,
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class _ValidatedDeepLinksView extends StatelessWidget {
Expanded(
child: ValueListenableBuilder<LinkData?>(
valueListenable: controller.selectedLink,
builder: (context, _, __) => TabBarView(
builder: (context, _, _) => TabBarView(
children: [
ValidationDetailView(
controller: controller,
Expand Down Expand Up @@ -313,7 +313,7 @@ class _ConfigurationDropdown extends StatelessWidget {
Widget build(BuildContext context) {
return ValueListenableBuilder(
valueListenable: valueListenable,
builder: (_, index, __) {
builder: (_, index, _) {
return Row(
children: [
Text(title),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class _DeepLinkPageState extends State<DeepLinkPage>
Widget build(BuildContext context) {
return ValueListenableBuilder(
valueListenable: controller.selectedProject,
builder: (_, FlutterProject? project, __) {
builder: (_, FlutterProject? project, _) {
return project == null
? const SelectProjectView()
: const DeepLinkListView();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ class _GenerateAssetLinksPanel extends StatelessWidget {
builder: (
_,
GenerateAssetLinksResult? generatedAssetLinks,
__,
_,
) {
return (generatedAssetLinks != null &&
generatedAssetLinks.errorCode.isNotEmpty)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,7 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
child: ValueListenableBuilder(
valueListenable: serviceConnection.errorBadgeManager
.erroredItemsForPage(InspectorScreen.id),
builder:
(_, LinkedHashMap<String, DevToolsError> errors, __) {
builder: (_, LinkedHashMap<String, DevToolsError> errors, _) {
final inspectableErrors = errors.map(
(key, value) =>
MapEntry(key, value as InspectableWidgetError),
Expand All @@ -203,7 +202,7 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
if (errors.isNotEmpty)
ValueListenableBuilder<int?>(
valueListenable: controller.selectedErrorIndex,
builder: (_, selectedErrorIndex, __) => Positioned(
builder: (_, selectedErrorIndex, _) => Positioned(
top: 0,
right: 0,
child: ErrorNavigator(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class InspectorControls extends StatelessWidget {
.hasServiceExtension(
extensions.toggleSelectWidgetMode.extension,
),
builder: (_, selectModeSupported, __) {
builder: (_, selectModeSupported, _) {
return ServiceExtensionButtonGroup(
fillColor: activeButtonColor,
extensions: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ class PubRootDirectorySection extends StatelessWidget {
return ValueListenableBuilder<IsolateRef?>(
valueListenable:
serviceConnection.serviceManager.isolateManager.mainIsolate,
builder: (_, __, ___) {
builder: (_, _, _) {
return SizedBox(
height: 200.0,
child: EditableList(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,7 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
child: ValueListenableBuilder(
valueListenable: serviceConnection.errorBadgeManager
.erroredItemsForPage(InspectorScreen.id),
builder:
(_, LinkedHashMap<String, DevToolsError> errors, __) {
builder: (_, LinkedHashMap<String, DevToolsError> errors, _) {
final inspectableErrors = errors.map(
(key, value) =>
MapEntry(key, value as InspectableWidgetError),
Expand All @@ -180,7 +179,7 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
if (errors.isNotEmpty)
ValueListenableBuilder<int?>(
valueListenable: controller.selectedErrorIndex,
builder: (_, selectedErrorIndex, __) => Positioned(
builder: (_, selectedErrorIndex, _) => Positioned(
top: 0,
right: 0,
child: ErrorNavigator(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class _WidgetDetailsState extends State<WidgetDetails> with AutoDisposeMixin {
Widget build(BuildContext context) {
return ValueListenableBuilder<InspectorTreeNode?>(
valueListenable: controller.selectedNode,
builder: (context, _, __) {
builder: (context, _, _) {
final node = selectedNode;
if (node == null) {
return const Center(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class _LoggingTableRowState extends State<LoggingTableRow> {
color: color,
child: ValueListenableBuilder<bool>(
valueListenable: widget.data.detailsComputed,
builder: (context, _, __) {
builder: (context, _, _) {
return Padding(
padding: const EdgeInsets.all(LoggingTableRow._padding),
child: Column(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class _LegendButton extends StatelessWidget {
Widget build(BuildContext context) {
return ValueListenableBuilder<bool>(
valueListenable: chartController.data.isLegendVisible,
builder: (_, legendVisible, __) => GaDevToolsButton(
builder: (_, legendVisible, _) => GaDevToolsButton(
onPressed: chartController.data.toggleLegendVisibility,
gaScreen: gac.memory,
gaSelection: legendVisible
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ class _MemoryChartPaneState extends State<MemoryChartPane>
const memoryEventsPainHeight = 70.0;
return ValueListenableBuilder<bool>(
valueListenable: preferences.memory.showChart,
builder: (_, showChart, __) {
builder: (_, showChart, _) {
if (!showChart) return const SizedBox.shrink();

return KeyboardListener(
Expand Down Expand Up @@ -184,7 +184,7 @@ class _MemoryChartPaneState extends State<MemoryChartPane>
widget.chart.data.isLegendVisible,
widget.chart.isAndroidChartVisible,
],
builder: (_, values, __) {
builder: (_, values, _) {
final isLegendVisible = values.first as bool;
final isAndroidChartVisible = values.second as bool;
if (!isLegendVisible) return const SizedBox.shrink();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class _SnapshotItemContent extends StatelessWidget {
Widget build(BuildContext context) {
return ValueListenableBuilder<SnapshotItem>(
valueListenable: controller.derived.selectedItem,
builder: (_, item, __) {
builder: (_, item, _) {
if (item is SnapshotDocItem) {
return Padding(
padding: const EdgeInsets.all(denseSpacing),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class HeapClassDetails extends StatelessWidget {

final selectedPathView = ValueListenableBuilder<PathData?>(
valueListenable: pathSelection,
builder: (_, pathData, __) {
builder: (_, pathData, _) {
if (pathData == null) {
return const CenteredMessage(
message: 'Click a table row to see the detailed path.',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class _PathControlPane extends StatelessWidget {
const SizedBox(width: denseSpacing),
ValueListenableBuilder<bool>(
valueListenable: controller.hideStandard,
builder: (_, hideStandard, __) => DevToolsFilterButton(
builder: (_, hideStandard, _) => DevToolsFilterButton(
onPressed: () {
ga.select(
gac.memory,
Expand All @@ -102,7 +102,7 @@ class _PathControlPane extends StatelessWidget {
const SizedBox(width: denseSpacing),
ValueListenableBuilder<bool>(
valueListenable: controller.invert,
builder: (_, invert, __) => DevToolsToggleButton(
builder: (_, invert, _) => DevToolsToggleButton(
onPressed: () {
ga.select(
gac.memory,
Expand Down Expand Up @@ -133,7 +133,7 @@ class _PathView extends StatelessWidget {
controller.hideStandard,
controller.invert,
],
builder: (_, values, __) {
builder: (_, values, _) {
final hideStandard = values.first as bool;
final invert = values.second as bool;
return SingleChildScrollView(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class _DiffDropdown extends StatelessWidget {
Widget build(BuildContext context) {
return ValueListenableBuilder<SnapshotDataItem?>(
valueListenable: current.diffWith,
builder: (_, diffWith, __) => Row(
builder: (_, diffWith, _) => Row(
children: [
const Text('Diff with:'),
const SizedBox(width: defaultSpacing),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class SnapshotListTitle extends StatelessWidget {

return FutureBuilder(
future: theItem is SnapshotDataItem ? theItem.process : null,
builder: (_, __) {
builder: (_, _) {
final isProcessing =
theItem is SnapshotDataItem ? !theItem.isProcessed : false;

Expand Down Expand Up @@ -388,7 +388,7 @@ class _SnapshotListItemsState extends State<_SnapshotListItems>
core.snapshots,
core.selectedSnapshotIndex,
],
builder: (_, values, __) {
builder: (_, values, _) {
final snapshots = values.first as List<SnapshotItem>;
final selectedIndex = values.second as int;
return ListView.builder(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class SnapshotView extends StatelessWidget {
controller.derived.singleClassesToShow,
controller.derived.diffClassesToShow,
],
builder: (_, values, __) {
builder: (_, values, _) {
final singleClasses = values.first as ClassDataList<SingleClassData>?;
final diffClasses = values.second as ClassDataList<DiffClassData>?;
if (controller.derived.updatingValues) {
Expand Down Expand Up @@ -58,7 +58,7 @@ class SnapshotView extends StatelessWidget {

final pathTable = ValueListenableBuilder<ClassData?>(
valueListenable: controller.derived.classData,
builder: (_, classData, __) => HeapClassDetails(
builder: (_, classData, _) => HeapClassDetails(
classData: classData,
pathSelection: controller.derived.selectedPath,
isDiff: classes is ClassDataList<DiffClassData>,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ class _AllocationTracingTableState extends State<AllocationTracingTable> {
widget.controller.refreshing,
widget.controller.selection,
],
builder: (context, values, __) {
builder: (context, values, _) {
final state = values.second as TracingIsolateState;
return ValueListenableBuilder<List<TracedClass>>(
valueListenable: state.filteredClassList,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ class HttpRequestView extends StatelessWidget {
Widget build(BuildContext context) {
return ListenableBuilder(
listenable: data,
builder: (context, __) {
builder: (context, _) {
final theme = Theme.of(context);
final requestHeaders = data.requestHeaders;
final requestContentType = requestHeaders?['content-type'] ?? '';
Expand Down Expand Up @@ -202,7 +202,7 @@ class HttpViewTrailingCopyButton extends StatelessWidget {
Widget build(BuildContext context) {
return ListenableBuilder(
listenable: data,
builder: (context, __) {
builder: (context, _) {
final dataToCopy = dataSelector(data);
final isLoading = data.isFetchingFullData;
if (dataToCopy == null || dataToCopy.isEmpty || isLoading) {
Expand Down Expand Up @@ -249,7 +249,7 @@ class HttpResponseTrailingDropDown extends StatelessWidget {
Widget build(BuildContext context) {
return ListenableBuilder(
listenable: data,
builder: (_, __) {
builder: (_, _) {
final visible = (data.contentType != null &&
!data.contentType!.contains('image')) &&
data.responseBody!.isNotEmpty;
Expand All @@ -265,7 +265,7 @@ class HttpResponseTrailingDropDown extends StatelessWidget {
replacement: const SizedBox(),
child: ValueListenableBuilder<NetworkResponseViewType>(
valueListenable: currentResponseViewType,
builder: (_, currentType, __) {
builder: (_, currentType, _) {
return RoundedDropDownButton<NetworkResponseViewType>(
value: currentType,
items: availableResponseTypes
Expand Down Expand Up @@ -305,7 +305,7 @@ class HttpResponseView extends StatelessWidget {
Widget build(BuildContext context) {
return ListenableBuilder(
listenable: data,
builder: (context, __) {
builder: (context, _) {
Widget child;
final theme = Theme.of(context);
// We shouldn't try and display an image response view when using the
Expand Down Expand Up @@ -356,7 +356,7 @@ class HttpTextResponseViewer extends StatelessWidget {
Widget build(BuildContext context) {
return ValueListenableBuilder(
valueListenable: currentResponseNotifier,
builder: (_, currentResponseType, __) {
builder: (_, currentResponseType, _) {
NetworkResponseViewType currentLocalResponseType = currentResponseType;

if (currentResponseType == NetworkResponseViewType.auto) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class WebPerformanceScreenBody extends StatelessWidget {
false;
return Markdown(
data: isFlutterWebApp ? flutterWebInstructionsMd : dartWebInstructionsMd,
onTapLink: (_, url, __) {
onTapLink: (_, url, _) {
if (url != null) {
unawaited(launchUrlWithErrorHandling(url));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ class _ProcessMemoryTreeMap extends StatelessWidget {
builder: (context, constraints) {
return ValueListenableBuilder<TreemapNode?>(
valueListenable: controller.treeMapRoot,
builder: (context, root, __) {
builder: (context, root, _) {
return Treemap.fromRoot(
rootNode: root!,
levelsVisible: 2,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class VMStatisticsViewBody extends StatelessWidget {
Expanded(
child: ValueListenableBuilder(
valueListenable: controller.refreshing,
builder: (context, _, __) {
builder: (context, _, _) {
return VMStatisticsWidget(
controller: controller,
);
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/shared/common_widgets.dart
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ class VisibilityButton extends StatelessWidget {
Widget build(BuildContext context) {
return ValueListenableBuilder<bool>(
valueListenable: show,
builder: (_, show, __) {
builder: (_, show, _) {
return GaDevToolsButton(
key: key,
tooltip: tooltip,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ import 'post_message.dart';
Stream<PostMessageEvent> get onPostMessage =>
throw UnsupportedError('unsupported platform');

void postMessage(Object? _, String __) =>
void postMessage(Object? _, String _) =>
throw UnsupportedError('unsupported platform');
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ class _ConsoleOutputState extends State<_ConsoleOutput>
physics: const ClampingScrollPhysics(
parent: RangeMaintainingScrollPhysics(),
),
separatorBuilder: (_, __) {
separatorBuilder: (_, _) {
return const PaddedDivider.noPadding();
},
itemBuilder: (context, index) {
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/lib/src/shared/editable_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class _EditableListState extends State<EditableList> {
widget.entries,
widget.isRefreshing ?? ValueNotifier<bool>(false),
],
builder: (_, __, ____) {
builder: (_, _, _) {
return Column(
mainAxisSize: MainAxisSize.min,
crossAxisAlignment: CrossAxisAlignment.start,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ class _TableRowState<T> extends State<TableRow<T>>
final expandIndicator = widget.isExpandable
? ValueListenableBuilder(
valueListenable: expandController,
builder: (context, _, __) {
builder: (context, _, _) {
return RotationTransition(
turns: expandArrowAnimation,
child: Icon(
Expand Down
Loading