Skip to content

License update - Batch 62#8777

Merged
mossmana merged 2 commits intoflutter:masterfrom
mossmana:8216-batch62
Jan 17, 2025
Merged

License update - Batch 62#8777
mossmana merged 2 commits intoflutter:masterfrom
mossmana:8216-batch62

Conversation

@mossmana
Copy link
Copy Markdown
Contributor

@mossmana mossmana commented Jan 16, 2025

Updates the license headers for:

  1. packages/devtools_shared/lib/devtools_server.dart
  2. packages/devtools_shared/lib/src/server/devtools_store.dart
  3. packages/devtools_shared/lib/src/server/file_system.dart
  4. packages/devtools_shared/lib/src/server/flutter_store.dart
  5. packages/devtools_shared/lib/src/server/handlers/_app_size.dart
  6. packages/devtools_shared/lib/src/server/handlers/_deeplink.dart
  7. packages/devtools_shared/lib/src/server/handlers/_devtools_extensions.dart
  8. packages/devtools_shared/lib/src/server/handlers/_dtd.dart
  9. packages/devtools_shared/lib/src/server/handlers/_general.dart
  10. packages/devtools_shared/lib/src/server/handlers/_preferences.dart
  11. packages/devtools_shared/lib/src/server/handlers/_release_notes.dart
  12. packages/devtools_shared/lib/src/server/handlers/_storage.dart
  13. packages/devtools_shared/lib/src/server/handlers/_survey.dart
  14. packages/devtools_shared/lib/src/server/server_api.dart
  15. packages/devtools_shared/test/server/deeplink_api_test.dart
  16. packages/devtools_shared/test/server/devtools_extensions_api_test.dart
  17. packages/devtools_shared/test/server/dtd_api_test.dart
  18. packages/devtools_shared/test/server/general_api_test.dart
  19. packages/devtools_shared/lib/service.dart
  20. packages/devtools_shared/test/service_utils_test.dart
  21. packages/devtools_shared/lib/src/service/service.dart
  22. packages/devtools_shared/lib/src/service_utils.dart
  23. packages/devtools_shared/lib/src/sse/_fake_sse.dart
  24. packages/devtools_shared/lib/src/sse/sse_shim.dart

#8216

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

kenzieschmoll
kenzieschmoll reviewed Jan 16, 2025
View reviewed changes
packages/devtools_shared/lib/src/service_utils.dart Outdated
Comment on lines 3 to 4
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
Copy link
Copy Markdown
Member

@kenzieschmoll kenzieschmoll Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double header

mossmana
mossmana commented Jan 16, 2025
View reviewed changes
packages/devtools_shared/lib/src/service_utils.dart Outdated
// Copyright 2025 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
// Copyright (c) 2022, the Dart project authors. Please see the AUTHORS file
Copy link
Copy Markdown
Contributor Author

@mossmana mossmana Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly copied from Dart SDK

Copy link
Copy Markdown
Member

@kenzieschmoll kenzieschmoll Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was not copied from anywhere. LIkely just a bad header.

kenzieschmoll
kenzieschmoll approved these changes Jan 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ one comment

@mossmana mossmana marked this pull request as ready for review January 17, 2025 19:52
@mossmana mossmana requested a review from bkonyi as a code owner January 17, 2025 19:52
@mossmana mossmana merged commit e90c6ac into flutter:master Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi Awaiting requested review from bkonyi bkonyi is a code owner

Assignees

No one assigned

Labels

release-notes-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mossmana @kenzieschmoll