Skip to content

[Property Editor] Label should always be at the top of the input#8819

Merged
elliette merged 1 commit intoflutter:masterfrom
elliette:null-string-fix
Jan 30, 2025
Merged

[Property Editor] Label should always be at the top of the input#8819
elliette merged 1 commit intoflutter:masterfrom
elliette:null-string-fix

Conversation

@elliette
Copy link
Copy Markdown
Member

@elliette elliette commented Jan 29, 2025

Work towards #1948

Previously, if a text input was empty (e.g. an empty string) the label text would display in the input box itself. This meant that most of the labels would be at the top of the input boxes, while others would show up in the input box:

Screenshot 2025-01-28 at 4 49 55 PM

This change makes sure the labels always stay at the top of the input box:

Screenshot 2025-01-28 at 4 49 24 PM

Note: I'm still trying to decide how/if we want to try to show the surrounding quotes for string inputs. For example above, that would mean showing '' in the input box instead of nothing.

@elliette elliette requested a review from a team as a code owner January 29, 2025 16:58
@elliette elliette requested review from kenzieschmoll and removed request for a team January 29, 2025 16:58
@elliette elliette merged commit c00e7e9 into flutter:master Jan 30, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants