[Property Editor] Label should always be at the top of the input#8819
Merged
elliette merged 1 commit intoflutter:masterfrom Jan 30, 2025
Merged
[Property Editor] Label should always be at the top of the input#8819elliette merged 1 commit intoflutter:masterfrom
elliette merged 1 commit intoflutter:masterfrom
Conversation
kenzieschmoll
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #1948
Previously, if a text input was empty (e.g. an empty string) the label text would display in the input box itself. This meant that most of the labels would be at the top of the input boxes, while others would show up in the input box:
This change makes sure the labels always stay at the top of the input box:
Note: I'm still trying to decide how/if we want to try to show the surrounding quotes for string inputs. For example above, that would mean showing
''in the input box instead of nothing.