Fix licence tool include/excludes for Windows#8843
Merged
DanTup merged 1 commit intoflutter:masterfrom Feb 5, 2025
Merged
Conversation
If the YAML file contains an exclusion using a forward slash then this condition would fail to match when running on Windows. This change uses `path.isWithin()` which handles the mismatched slashes automatically. This fixes some test failures when running the licence tests on Windows.
mossmana
approved these changes
Feb 5, 2025
Contributor
mossmana
left a comment
mossmana
left a comment
There was a problem hiding this comment.
Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the YAML file contains an exclusion using a forward slash then this condition would fail to match when running on Windows. This change uses
path.isWithin()which handles the mismatched slashes automatically.This fixes some test failures when running the licence tests on Windows.
CC @mossmana