Add support for universal banner messages#8995
Merged
kenzieschmoll merged 3 commits intoflutter:masterfrom Mar 6, 2025
Merged
Conversation
elliette
reviewed
Mar 6, 2025
elliette
reviewed
Mar 6, 2025
elliette
reviewed
Mar 6, 2025
| /// | ||
| /// Messages with this screen id will be added to the list of messages for | ||
| /// every screen from the [BannerMessages] widget. | ||
| const universalBannerMessageId = 'universal'; |
Member
There was a problem hiding this comment.
Is the banner ID the same as the banner key? (Can there be more than one universal banner? Does dismissing one of them dismiss all of them?)
Member
Author
There was a problem hiding this comment.
Good question. No this is the ID to use for the screen, not the ID for the banner message itself. There can be more than one banner message with this screen id, much like there can be multiple banner messages for any other screen id. I will rename this to universalScreenId to make this less confusing. Banner messages are still identified by their key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Banner messages added with the universal id
universalBannerMessageIdwill show up on every DevTools screen.Follow up to #8995 and part of the work to address #7002.