Tidy some code in the integration testing. Namely: #8996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert the FlutterDaemonConstants from an enum into a namespaced set of constant strings. In all cases, each enum value was only used to access the 'key' string, so this simplifies to that reality. Also they weren't used as an enumeration. * Reduce the number of JSON map lookups. This makes the code more concise. * Use the `.option`, `.multiOption`, and `.flag` APIs from package:args, avoiding dynamic casting.
kenzieschmoll
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.option,.multiOption, and.flagAPIs from package:args, avoiding dynamic casting.TestRunnerArgsin the constructor initializers, allowing them to be non-late.