Skip to content

Fix alignment issues in DevToolsClearableTextField #9054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 3 commits into from
Mar 21, 2025
Merged

Fix alignment issues in DevToolsClearableTextField #9054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8eec532
Fix text field alignment issues
elliette Mar 20, 2025
1175c28
Remove unused field
elliette Mar 20, 2025
3982685
Update CHANGELOG and goldens
elliette Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...s/devtools_app/test/test_infra/goldens/memory/load_offline_data_profile_tab.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ges/devtools_app/test/test_infra/goldens/memory/load_offline_data_trace_tab.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/devtools_app_shared/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ getter.
* Move the `Disposable` class from the
`package:devtools_app_shared/service.dart` library to the
`package:devtools_app_shared/utils.dart` library.
* Fix alignment issues in `DevToolsClearableTextField`.

## 0.3.1
* Bump `vm_service` dependency to `>=13.0.0 <16.0.0`.
Expand Down
39 changes: 19 additions & 20 deletions packages/devtools_app_shared/lib/src/ui/text_field.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ final class DevToolsClearableTextField extends StatelessWidget {
final bool? enabled;
final bool roundedBorder;

static const _contentVerticalPadding = 6.0;

/// This is the default border radius used by the [OutlineInputBorder]
/// constructor.
static const _defaultInputBorderRadius =
Expand All @@ -45,8 +43,10 @@ final class DevToolsClearableTextField extends StatelessWidget {
Widget build(BuildContext context) {
final theme = Theme.of(context);
return SizedBox(
height: defaultTextFieldHeight,
height: defaultTextFieldHeight + densePadding,
child: TextField(
textAlignVertical: TextAlignVertical.center,
cursorHeight: defaultTextFieldHeight / 2,
autofocus: autofocus,
controller: controller,
enabled: enabled,
Expand All @@ -56,10 +56,9 @@ final class DevToolsClearableTextField extends StatelessWidget {
decoration: InputDecoration(
isDense: true,
contentPadding: const EdgeInsets.only(
top: _contentVerticalPadding,
bottom: _contentVerticalPadding,
top: densePadding,
bottom: densePadding,
left: denseSpacing,
right: densePadding,
),
constraints: BoxConstraints(
minHeight: defaultTextFieldHeight,
Expand All @@ -75,20 +74,20 @@ final class DevToolsClearableTextField extends StatelessWidget {
hintText: hintText,
hintStyle: theme.subtleTextStyle,
prefixIcon: prefixIcon,
suffix: SizedBox(
height: inputDecorationElementHeight,
child: Row(
mainAxisSize: MainAxisSize.min,
children: [
...additionalSuffixActions,
InputDecorationSuffixButton.clear(
onPressed: () {
controller.clear();
onChanged?.call('');
},
),
],
),
suffixIcon: SizedBox(
height: inputDecorationElementHeight,
child: Row(
mainAxisSize: MainAxisSize.min,
children: [
...additionalSuffixActions,
InputDecorationSuffixButton.clear(
onPressed: () {
controller.clear();
onChanged?.call('');
},
),
],
),
),
),
),
Expand Down
Loading