Skip to content

Remove unused field FilterDialog.filteredName #9070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srawlins merged 1 commit into from
Mar 26, 2025
Merged

Remove unused field FilterDialog.filteredName #9070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/devtools_app/lib/src/screens/profiler/cpu_profiler.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,8 @@ class _CpuProfilerState extends State<CpuProfiler>
showDialog(
context: context,
builder:
(context) => FilterDialog<CpuStackFrame>(
controller: widget.controller,
filteredItem: 'stack frame',
),
(context) =>
FilterDialog<CpuStackFrame>(controller: widget.controller),
),
);
}
Expand Down
20 changes: 7 additions & 13 deletions packages/devtools_app/lib/src/shared/ui/filter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,21 +192,16 @@ mixin FilterControllerMixin<T> on DisposableController
/// This dialog interacts with a [FilterControllerMixin] to manage and preserve
/// the filter state.
class FilterDialog<T> extends StatefulWidget {
FilterDialog({
super.key,
required this.controller,
required this.filteredItem,
}) : assert(controller.queryFilterArgs.isNotEmpty),
settingFilterValuesAtOpen = List.generate(
controller.activeFilter.value.settingFilters.length,
(index) =>
controller.activeFilter.value.settingFilters[index].setting.value,
);
FilterDialog({super.key, required this.controller})
: assert(controller.queryFilterArgs.isNotEmpty),
settingFilterValuesAtOpen = List.generate(
controller.activeFilter.value.settingFilters.length,
(index) =>
controller.activeFilter.value.settingFilters[index].setting.value,
);

final FilterControllerMixin<T> controller;

final String filteredItem;

final List<Object> settingFilterValuesAtOpen;

@override
Expand Down Expand Up @@ -693,7 +688,6 @@ class _StandaloneFilterFieldState<T> extends State<StandaloneFilterField<T>>
builder:
(context) => FilterDialog(
controller: widget.controller,
filteredItem: widget.filteredItem,
),
),
);
Expand Down
Loading