Skip to content

Support horizontal scrolling in tree tables. Fixes regression. #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 1 commit into from
Aug 14, 2019
Merged

Support horizontal scrolling in tree tables. Fixes regression. #925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/devtools/lib/src/tables.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,13 @@ class Table<T> with SetStateMixin implements TableDataClient<T> {
factory Table.virtual({double rowHeight = 29.0}) =>
Table._(TableData<T>(), rowHeight, true);

Table._(this.model, this.rowHeight, this.isVirtual)
: assert(model.client == null) {
Table._(
this.model,
this.rowHeight,
this.isVirtual, {
bool overflowAuto = false,
}) : assert(model.client == null) {
model.client = this;
const bool overflowAuto = false;
element = isVirtual
? div(
a: 'flex',
Expand Down Expand Up @@ -527,7 +530,7 @@ class TreeTable<T extends TreeNode<T>> extends Table<T> {
TreeTable._(TreeTableData<T>(), rowHeight, true);

TreeTable._(TreeTableData<T> model, double rowHeight, bool isVirtual)
: super._(model, rowHeight, isVirtual);
: super._(model, rowHeight, isVirtual, overflowAuto: true);

@override
TreeTableData<T> get model => super.model;
Expand Down