Add a skill for closing obsolete issues#9812
Conversation
kenzieschmoll
requested review from
bkonyi and
srawlins
and removed request for
a team
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new skill for identifying and closing obsolete issues in the flutter/devtools repository, including a rationale template and a helper script for fetching issue details. Feedback was provided regarding the robustness of the issue fetching script when encountering deleted users and the inclusion of unrelated dependency updates in the lockfile.
|
|
||
| - Use `grep_search` or `find_by_name` to check the current codebase for references to the issue or relevant code. | ||
| - Look for related PRs that might have fixed the issue but didn't close it automatically. | ||
| - For issues reporting specific versions, check the current DevTools version in `packages/devtools_app/pubspec.yaml` to determine if the reported version is very old. |
There was a problem hiding this comment.
I'm a little worried that an agent will just use this rationale alone to close old issues. Like if an issue was reported against DevTools 2.55 and we're at DevTools 2.58, what is actionable about that? I don't think we want to close issues that are just old. I don't think we want to ask for confirmation that old issues are still issues.
There was a problem hiding this comment.
This skill does not automatically close any issues, but rather creates a report with rationale and draft comments. Once the user reviews and tells the agent to proceed, it will close the issues with the drafted comment. So if the agent gives a false positive on what it deems "very old" to be, then the user can tell it as much and tell it to fix the skill to ensure that doesn't keep happening.
3 participants
Fixes #9800
This PR also updates
TRIAGE.mdto use this skill with an agent (and updates stale owners while I am touching this file).