Skip to content

Use default service extension states in UI even when they are not available#9813

Merged
kenzieschmoll merged 4 commits intoflutter:masterfrom
kenzieschmoll:profilemodefix
Apr 30, 2026
Merged

Use default service extension states in UI even when they are not available#9813
kenzieschmoll merged 4 commits intoflutter:masterfrom
kenzieschmoll:profilemodefix

Conversation

@kenzieschmoll
Copy link
Copy Markdown
Member

Fixes #4083

@kenzieschmoll kenzieschmoll requested a review from a team as a code owner April 29, 2026 23:22
@kenzieschmoll kenzieschmoll requested review from elliette and srawlins and removed request for a team April 29, 2026 23:22
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies ServiceExtensionCheckbox to display its state regardless of extension availability, fixing a bug where debug options appeared unselected in profile mode. The changes include removing an availability check in _initExtensionState and adding a new test case to verify this behavior. Feedback was provided to replace a placeholder link in the release notes with the actual pull request number.


TODO: Remove this section if there are not any updates.
- Fixed an issue where 'More Debug Options' showed options as unselected in
profile mode even when selected. [TODO](https://github.com/flutter/devtools/pull/TODO)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[CONCERN]: The link for the pull request is a [TODO] placeholder. Please update this with the correct pull request number before merging.

@kenzieschmoll kenzieschmoll merged commit 9265adf into flutter:master Apr 30, 2026
88 of 89 checks passed
@kenzieschmoll kenzieschmoll deleted the profilemodefix branch April 30, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More Debug Options are unselected while in profile mode

2 participants