Skip to content

Update dart_skills_lint dependency to e449787 and centralize test configuration#9830

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
reidbaker:update-dart-skills-lint-2026-05-14
May 14, 2026
Merged

Update dart_skills_lint dependency to e449787 and centralize test configuration#9830
auto-submit[bot] merged 1 commit into
flutter:masterfrom
reidbaker:update-dart-skills-lint-2026-05-14

Conversation

@reidbaker
Copy link
Copy Markdown
Contributor

Updates the pinned dart_skills_lint reference in tool/pubspec.yaml to commit hash e4497873950727ee781fa411c1a2f624b1ec50c6 (version 0.3.0). Refactors tool/test/validate_skills_test.dart to load configuration dynamically via ConfigParser.loadConfig and omit targeting overrides, enabling native path inheritance from tool/dart_skills_lint.yaml.

Pre-launch Checklist

General checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I updated/added relevant documentation (doc comments with ///).

Issues checklist

  • I listed at least one issue that this PR fixes in the description above.
  • I listed at least one issue which has the [contributions-welcome] or [good-first-issue] label.
  • I did not list at least one issue with the [contributions-welcome] or [good-first-issue] label. I understand this means my PR might take longer to be reviewed.

Tests checklist

  • I added new tests to check the change I am making...
  • OR there is a reason for not adding tests, which I explained in the PR description.

AI-tooling checklist

  • I did not use any AI tooling in creating this PR.
  • OR I did use AI tooling, and...
    • I read the [AI contributions guidelines] and agree to follow them.
    • I reviewed all AI-generated code before opening this PR.
    • I understand and am able to discuss the code in this PR.
    • I have verifed the accuracy of any AI-generated text included in the PR description.
    • I commit to verifying the accuracy of any AI-generated code or text that I upload in response to review comments.

Feature-change checklist

  • This PR does not change the DevTools UI or behavior and...
    • I added the release-notes-not-required label or left a comment requesting the label be added.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dart_skills_lint dependency to version 0.3.0 and refactors the validate_skills_test.dart to use a configuration file (dart_skills_lint.yaml) via ConfigParser instead of hardcoded values. This change fulfills a previous TODO and streamlines the skill validation process. I have no feedback to provide.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label May 14, 2026
@auto-submit auto-submit Bot merged commit 5122355 into flutter:master May 14, 2026
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App release-notes-not-required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants