Add pin rows to Profile Memory table#9832
Open
khanak0509 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to pin classes to the top of the Profile Memory table in DevTools. The implementation involves updating the AdaptedProfile and ProfileRecord models to track pinning status, adding pinning logic and serialization to the ProfilePaneController, and creating a new _PinColumn for the UI. Review feedback identifies a logical issue where the pinned classes listener is not updated during initialization, suggests improving the stateful widget's resilience to controller changes, and highlights performance concerns regarding redundant builders and inefficient key generation for the table.
…file_pane_controller.dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…file_view.dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8898
Trace Instances already keeps traced classes at the top (via the checkbox), but Profile Memory didn’t have anything similar
This PR adds a Pin column to Profile Memory. Tap the pin icon on a row and that class stays in the pinned section at the top (under All Classes), with a divider between pinned and the rest of the table, same general idea as Trace Instances, but without turning on allocation tracing
before
after
Pre-launch Checklist
General checklist
///).Issues checklist
contributions-welcomeorgood-first-issuelabel.contributions-welcomeorgood-first-issuelabel. I understand this means my PR might take longer to be reviewed.Tests checklist
AI-tooling checklist
Feature-change checklist
release-notes-not-requiredlabel or left a comment requesting the label be added.packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md.If you need help, consider asking for help on Discord.