Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit e623b2b

Browse files
Remove LSAN supressions for Linux embedder (#56913)
Fixes flutter/flutter#90155
1 parent 7e23aa3 commit e623b2b

File tree

3 files changed

+3
-9
lines changed

3 files changed

+3
-9
lines changed

shell/platform/linux/fl_basic_message_channel_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ TEST(FlBasicMessageChannelTest, SendMessageWithoutResponse) {
4343
g_bytes_new(message->message, message->message_size);
4444
g_autoptr(FlStandardMessageCodec) codec =
4545
fl_standard_message_codec_new();
46-
FlValue* message_value = fl_message_codec_decode_message(
46+
g_autoptr(FlValue) message_value = fl_message_codec_decode_message(
4747
FL_MESSAGE_CODEC(codec), message_bytes, nullptr);
4848
EXPECT_EQ(fl_value_get_type(message_value), FL_VALUE_TYPE_STRING);
4949
EXPECT_STREQ(fl_value_get_string(message_value), "Hello World!");

shell/platform/linux/fl_key_event_channel.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,13 @@ gboolean fl_key_event_channel_send_finish(GObject* object,
109109
GAsyncResult* result,
110110
gboolean* handled,
111111
GError** error) {
112-
FlValue* message = fl_basic_message_channel_send_finish(
112+
g_autoptr(FlValue) message = fl_basic_message_channel_send_finish(
113113
FL_BASIC_MESSAGE_CHANNEL(object), result, error);
114114
if (message == nullptr) {
115115
return FALSE;
116116
}
117117

118-
g_autoptr(FlValue) handled_value = fl_value_lookup_string(message, "handled");
118+
FlValue* handled_value = fl_value_lookup_string(message, "handled");
119119
*handled = fl_value_get_bool(handled_value);
120120

121121
return TRUE;

testing/lsan_suppressions.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,6 @@ leak:RefCountedTest_DebugChecks_Test::TestBody
5050
# and allow some tests to inspect contents.
5151
leak:*flutter/shell/platform/linux/testing/mock_engine.cc
5252

53-
# TODO(bdero): Fix FL leaks: https://github.com/flutter/flutter/issues/90155
54-
leak:*flutter/shell/platform/linux/fl_keyboard_handler_test.cc*
55-
leak:*flutter/shell/platform/linux/fl_key_channel_responder_test.cc*
56-
leak:*flutter/shell/platform/linux/fl_basic_message_channel_test.cc*
57-
leak:fl_message_codec_decode_message
58-
5953
# TODO(bdero): https://github.com/flutter/flutter/issues/90156
6054
# Unfortunately, realloc calls originating from g_realloc effectively obscure
6155
# the trace of the original allocation. Deeper investigation is required to

0 commit comments

Comments
 (0)