Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix iOS key events in platform views #26412

Merged
merged 1 commit into from
May 26, 2021
Merged

Fix iOS key events in platform views #26412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1096,26 +1096,33 @@ - (void)dispatchPresses:(NSSet<UIPress*>*)presses API_AVAILABLE(ios(13.4)) {
}
}

- (void)pressesBegan:(NSSet<UIPress*>*)presses withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) {
- (void)pressesBegan:(NSSet<UIPress*>*)presses
withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) {
[super pressesBegan:presses withEvent:event];
if (@available(iOS 13.4, *)) {
[self dispatchPresses:presses];
}
}

- (void)pressesChanged:(NSSet<UIPress*>*)presses withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) {
- (void)pressesChanged:(NSSet<UIPress*>*)presses
withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) {
[super pressesChanged:presses withEvent:event];
if (@available(iOS 13.4, *)) {
[self dispatchPresses:presses];
}
}

- (void)pressesEnded:(NSSet<UIPress*>*)presses withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) {
- (void)pressesEnded:(NSSet<UIPress*>*)presses
withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) {
[super pressesEnded:presses withEvent:event];
Copy link

@fbartho fbartho Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have been moved to end-of-method?

Just like onViewDidDisappear

if (@available(iOS 13.4, *)) {
[self dispatchPresses:presses];
}
}

- (void)pressesCancelled:(NSSet<UIPress*>*)presses
withEvent:(UIEvent*)event API_AVAILABLE(ios(9.0)) {
withEvent:(UIPressesEvent*)event API_AVAILABLE(ios(9.0)) {
[super pressesCancelled:presses withEvent:event];
Copy link

@fbartho fbartho Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have been moved to end-of-method?

Just like onViewDidDisappear

if (@available(iOS 13.4, *)) {
[self dispatchPresses:presses];
}
Expand Down