Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

fix set clip data crashes on a few phones#32832

Closed
wangying3426 wants to merge 1 commit intoflutter:mainfrom
wangying3426:fix_set_clip_crash
Closed

fix set clip data crashes on a few phones#32832
wangying3426 wants to merge 1 commit intoflutter:mainfrom
wangying3426:fix_set_clip_crash

Conversation

@wangying3426
Copy link
Copy Markdown
Contributor

@wangying3426 wangying3426 commented Apr 21, 2022

Fixed flutter/flutter#102300

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chinmaygarde
Copy link
Copy Markdown
Contributor

This will need a test. Reading the linked issue, I am also not sure if there is a reproduction.

cc @blasten

@wangying3426
Copy link
Copy Markdown
Contributor Author

wangying3426 commented Apr 22, 2022

This will need a test. Reading the linked issue, I am also not sure if there is a reproduction.

cc @blasten

According to the linked issue, this crash is very difficult to reproduction. Meanwhile, there are some setPrimaryClip calls in other tests, such as getClipboardData test case, these tests will fail if setPrimaryClip crashed.

Therefore, can this PR apply for exemption from the test? If test really need, whether this test of this commit meets the requirements? If ok, i will merge it later. Thanks.

@zanderso
Copy link
Copy Markdown
Member

From PR triage: We're uncertain of the correct usage of this API, but it seems like simply discarding the exception is probably not the right approach. I'm going to close this PR, but if we get some expert advice (@blasten) it might make sense to re-open and continue with it.

@zanderso zanderso closed this Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

set clipboard data crashed on few phones

3 participants