fix set clip data crashes on a few phones#32832
fix set clip data crashes on a few phones#32832wangying3426 wants to merge 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This will need a test. Reading the linked issue, I am also not sure if there is a reproduction. cc @blasten |
According to the linked issue, this crash is very difficult to reproduction. Meanwhile, there are some setPrimaryClip calls in other tests, such as getClipboardData test case, these tests will fail if setPrimaryClip crashed. Therefore, can this PR apply for exemption from the test? If test really need, whether this test of this commit meets the requirements? If ok, i will merge it later. Thanks. |
|
From PR triage: We're uncertain of the correct usage of this API, but it seems like simply discarding the exception is probably not the right approach. I'm going to close this PR, but if we get some expert advice (@blasten) it might make sense to re-open and continue with it. |
Fixed flutter/flutter#102300
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.