This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Updates accessible_navigation trigger in Android #35478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
cc @dnfield |
dnfield
reviewed
Aug 18, 2022
| // Use the setter to update this property if needed. | ||
| @VisibleForTesting public boolean hasAssistiveTechnology = false; | ||
|
|
||
| private void setHasAssistiveTechnology(boolean value) { |
Contributor
There was a problem hiding this comment.
nitpick: Maybe call this updateHasAssistiveTechnology. Alternatively, require sendLatestAccessibilityFlagsToFlutter to take a boolean and have it set the flags. Then in tests you don't need the extra flag taken.
Contributor
Author
There was a problem hiding this comment.
I meant to make this a setter of hasAssistiveTechnology. I am very lazy so I just search online, this is the common way people name it. WDYT?
sendLatestAccessibilityFlagsToFlutter sends the entire feature flags over, unless I create an API specific for ACCESSIBLE_NAVIGATION it feels weird to add an parameter to sendLatestAccessibilityFlagsToFlutter for ACCESSIBLE_NAVIGATION only.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 19, 2022
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flutter/flutter#109521
There isn't an API to detect whether voice access and switch access is running. Android team also shift away the strategy from exposing the state of assistive technology. Their strategies are exposing API that targets specific use case. For example, most app need to know whether assistive technologies are running to decide modal fadeout durations. So Android team expose adhoc getRecommendedTimeoutMillis for this use case. Unfortunately we can't use these adhoc API due to the reason mentioned in flutter/flutter#109521 (comment). Therefore, I implement this pr to workaround the issue.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.