This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Hold the TestRunner's platform view through a shared_ptr#3870
Merged
jason-simmons merged 1 commit intoflutter:masterfrom Jul 12, 2017
Merged
Hold the TestRunner's platform view through a shared_ptr#3870jason-simmons merged 1 commit intoflutter:masterfrom
jason-simmons merged 1 commit intoflutter:masterfrom
Conversation
flutter_tester was throwing a bad_weak_ptr while setting up the engine because the PlatformViewTest was held in a unique_ptr
Member
Author
|
@cbracken @chinmaygarde this fix may need to be ported over to iOS |
goderbauer
added a commit
to goderbauer/engine
that referenced
this pull request
Jul 12, 2017
Related to flutter#3870.
Merged
Member
|
For iOS: #3871 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter_tester was throwing a bad_weak_ptr while setting up the engine
because the PlatformViewTest was held in a unique_ptr