Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix engine on iOS#4113

Merged
B3rn475 merged 1 commit intoflutter:masterfrom
B3rn475:ios
Sep 15, 2017
Merged

Fix engine on iOS#4113
B3rn475 merged 1 commit intoflutter:masterfrom
B3rn475:ios

Conversation

@B3rn475
Copy link
Contributor

@B3rn475 B3rn475 commented Sep 15, 2017

Related #4105

@aam
Copy link
Member

aam commented Sep 15, 2017

The patch have fixed compilation error that I got at the tip:

/Source/vsync_waiter_ios.mm -o obj/flutter/shell/platform/darwin/ios/libFlutter/vsync_waiter_ios.o
../../flutter/shell/platform/darwin/ios/framework/Source/vsync_waiter_ios.mm:65:49: error: invalid operands to binary expression ('fxl::TimePoint' and 'int')
    sprintf(deadline, "%lld", frame_target_time / 1000);  // microseconds
                              ~~~~~~~~~~~~~~~~~ ^ ~~~~

@aam
Copy link
Member

aam commented Sep 15, 2017

So LGTM

@B3rn475 B3rn475 merged commit 2820d0e into flutter:master Sep 15, 2017
@B3rn475 B3rn475 deleted the ios branch September 15, 2017 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants