This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Use iOS scale when computing render buffer size (#4171)"#4175
Merged
cbracken merged 1 commit intoflutter:masterfrom Oct 5, 2017
cbracken:revert-scale
Merged
Revert "Use iOS scale when computing render buffer size (#4171)"#4175cbracken merged 1 commit intoflutter:masterfrom cbracken:revert-scale
cbracken merged 1 commit intoflutter:masterfrom
cbracken:revert-scale
Conversation
This reverts commit d43d353. Clear regression to the flutter_gallery_ios__transition_perf benchmarks: * average_frame_build_time_millis: 1.4x * missed_frame_build_budget_count: 1.2x No regression seen for other iOS benchmarks (e.g. scrolling).
Member
Author
|
Reverting while investigating the perf regression to the Gallery frame build benchmark. |
Contributor
|
The build times should only affect the rasterizer. I don't see how this patch affects engine times. |
chinmaygarde
approved these changes
Oct 4, 2017
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
It is not clear to me how a change in the rasterizer is affecting build times (and that too only for certain benchmarks). We can revert this patch till we get more traces.
Contributor
|
LGTM Feel free to check in reverts with just TBR= |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d43d353.
Clear regression to the flutter_gallery_ios__transition_perf benchmarks:
No regression seen for other iOS benchmarks (e.g. scrolling).