This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update to use new vulkan GrBackendRenderTarget ctor.#4962
Merged
brianosman merged 1 commit intoflutter:masterfrom Apr 10, 2018
Merged
Update to use new vulkan GrBackendRenderTarget ctor.#4962brianosman merged 1 commit intoflutter:masterfrom
brianosman merged 1 commit intoflutter:masterfrom
Conversation
This moves to the new skia ctor for vulkan GrBackendRenderTarget which doesn't take a stencil count since vulkan doesn't bind stencil and render target together like GL does with framebuffer so it is not needed.
egdaniel
added a commit
to egdaniel/engine
that referenced
this pull request
Apr 10, 2018
This moves to the new skia ctor for vulkan GrBackendRenderTarget which doesn't take a stencil count since vulkan doesn't bind stencil and render target together like GL does with framebuffer so it is not needed. This is the same idea as pull, flutter#4962, but the github UI was only allowing me to change one file via the online edit :(
Contributor
Author
brianosman
pushed a commit
that referenced
this pull request
Apr 10, 2018
This moves to the new skia ctor for vulkan GrBackendRenderTarget which doesn't take a stencil count since vulkan doesn't bind stencil and render target together like GL does with framebuffer so it is not needed. This is the same idea as pull, #4962, but the github UI was only allowing me to change one file via the online edit :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves to the new skia ctor for vulkan GrBackendRenderTarget which doesn't take a stencil count since vulkan doesn't bind stencil and render target together like GL does with framebuffer so it is not needed.