Revert "[Impeller] switch Pipeline to use raw ptr instead of shared ptr for recorded references." #57079
Conversation
…tr for r…" This reverts commit 4d0e9ac.
|
I was unable to verify the revert fixes this issue since the flake doesn't seem to be able to be reproduced by isolating the failing test. All failures show up after this PR and the ones after it are opengles and a skia role so they are unlikely to have caused it, while this one did change pipelines. |
|
LGTM |
gaaclarke
added
the
revert
|
Is the revert PR going to merge automatically or does it need approval? I can't remember. |
|
should be automatic, provided the bot created it |
|
oh, you manually created the revert. You need to add the label to the original PR with a comment, then the bot will merge it ASAP. |
Pedantic note: I didn't manually merge it. I pressed the "revert" button in the github ui. |
|
landing on red to open the tree since I dun goofed the revert bot |
…f shared ptr for recorded references." (flutter/engine#57079)
…160011) flutter/engine@2069db8...0338d1c 2024-12-10 30870216+gaaclarke@users.noreply.github.com Revert "[Impeller] switch Pipeline to use raw ptr instead of shared ptr for recorded references." (flutter/engine#57079) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…tr for recorded references." (flutter/engine#57079) Reverts flutter/engine#57015 fixes flutter#160004
2 participants
Reverts #57015
fixes flutter/flutter#160004