Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

liyuqian
Copy link
Contributor

Reverts #6442

container_layer.h file is not synced which broke the bots

@liyuqian liyuqian requested a review from chinmaygarde October 11, 2018 21:17
@liyuqian liyuqian merged commit c6e6da5 into master Oct 11, 2018
liyuqian added a commit to liyuqian/engine that referenced this pull request Oct 11, 2018
liyuqian added a commit that referenced this pull request Oct 11, 2018
* Revert "Revert "Allow raster caching any layer subtree (#6442)" (#6506)"

This reverts commit c6e6da5.

* Use raw pointer for RasterCacheKey

So we won't depend on whether it's a std::unique_ptr or std::shared_ptr.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 11, 2018
flutter/engine@9cad7b6...c6e6da5

git log 9cad7b6..c6e6da5 --no-merges --oneline
c6e6da5 Revert "Allow raster caching any layer subtree (flutter#6442)" (flutter/engine#6506)
6447418 Allow raster caching any layer subtree (flutter/engine#6442)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 12, 2018
flutter/engine@9cad7b6...daf4447

git log 9cad7b6..daf4447 --no-merges --oneline
daf4447 Reland "Allow raster caching any layer subtree (flutter#6442)" (flutter/engine#6507)
c6e6da5 Revert "Allow raster caching any layer subtree (flutter#6442)" (flutter/engine#6506)
6447418 Allow raster caching any layer subtree (flutter/engine#6442)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 12, 2018
flutter/engine@9cad7b6...daf4447

git log 9cad7b6..daf4447 --no-merges --oneline
daf4447 Reland "Allow raster caching any layer subtree (#6442)" (flutter/engine#6507)
c6e6da5 Revert "Allow raster caching any layer subtree (#6442)" (flutter/engine#6506)
6447418 Allow raster caching any layer subtree (flutter/engine#6442)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@cbracken cbracken deleted the revert-6442-cache_layer branch November 26, 2018 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants