This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "Allow raster caching any layer subtree (#6442)" #6507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter#6506)" This reverts commit c6e6da5.
So we won't depend on whether it's a std::unique_ptr or std::shared_ptr.
liyuqian
force-pushed
the
cache_layer2
branch
from
f5842a4 to
c9ba6a8
Compare
chinmaygarde
approved these changes
Oct 11, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2018
flutter/engine@9cad7b6...daf4447 git log 9cad7b6..daf4447 --no-merges --oneline daf4447 Reland "Allow raster caching any layer subtree (flutter#6442)" (flutter/engine#6507) c6e6da5 Revert "Allow raster caching any layer subtree (flutter#6442)" (flutter/engine#6506) 6447418 Allow raster caching any layer subtree (flutter/engine#6442) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 12, 2018
flutter/engine@9cad7b6...daf4447 git log 9cad7b6..daf4447 --no-merges --oneline daf4447 Reland "Allow raster caching any layer subtree (#6442)" (flutter/engine#6507) c6e6da5 Revert "Allow raster caching any layer subtree (#6442)" (flutter/engine#6506) 6447418 Allow raster caching any layer subtree (flutter/engine#6442) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c6e6da5.
Additionally, we use raw pointer for RasterCacheKey so we won't depend on whether it's a std::unique_ptr or std::shared_ptr.