Start paused during run mode #4622

helin24 · 2020-06-12T20:59:49Z

App should be paused on run mode as well as on debug mode so we won't miss any events from the beginning of an app's running.

Verified that a project can be run without hangs in run mode (no breakpoints), profile mode, and release mode.

jacob314 · 2020-06-12T21:39:32Z

src/io/flutter/sdk/FlutterSdk.java

    }

-    if (mode == RunMode.DEBUG) {
+    if (mode == RunMode.DEBUG || mode == RunMode.RUN) {


is there any other mode? also make sure we are not breaking release/profile mode.

There is also RunMode.PROFILE - I guess it would make sense to enable --start-paused for all of the IntelliJ modes (so in that case just remove this conditional)?

I'm having trouble testing flutter profile mode and release mode. Do I need to go through some additional setup steps for this? I se this doc for iOS at least https://flutter.dev/docs/deployment/ios

jacob314 · 2020-06-13T18:02:38Z

gmcdowell · 2020-06-29T01:06:36Z

Guys it looks like you have caused considerable chaos for us Flutter Developers with this change.

In short when I now run a Flutter Test via IntelliJ, tests no longer run at all as you have paused them with NO way of changing this behaviour.

Please revert

blasko · 2020-06-29T01:13:36Z

This is a full stop breaking change that needs to be addressed asap.

franferri · 2020-06-29T08:28:49Z

Same problem here.

This reverts commit c241d2e.

benoitskipr · 2020-06-29T16:56:13Z

running them in debug mode shows the error in console still, but tests run (as a temp fix)

franferri · 2020-06-29T17:08:57Z

I have open a TT to flutter themselves: flutter/flutter#60486 (comment)
Maybe I had to post it here

franferri · 2020-06-29T17:10:19Z

I have installed today in Android Studio the plugins Flutter and Dart. Last versions.

I was working for hours doing tests in my project and after the update suddenly I can't run the Flutter tests anymore, it keeps saying:

Warning: You should set `SILENT_OBSERVATORY` to true when debugging the VM as it will output the observatory URL by default.
This breaks the various reporter contracts.
To set the value define `DART_VM_OPTIONS=-DSILENT_OBSERVATORY=true`.

I'm using macOS last version with Flutter stable channel:

Flutter 1.17.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 1ad9baa8b9 (11 days ago) • 2020-06-17 14:41:16 -0700
Engine • revision ee76268252
Tools • Dart 2.8.4
I have tried to add the DART_VM_OPTIONS=-DSILENT_OBSERVATORY=true to the environment, export in a console and then start Android Studio with open -a... nothing works.

Either Flutter is rewriting the var or the build-in dart-sdk not picking it.

Since setting the variable as global don't work, nor in the terminal session before running Android Studio, nor Android Studio let you change anything in the dart plugin panel... I'm out of options

if anybody knows how to fix this please help.

Posted in stackoverflow too in a desperate attempt to get help: https://stackoverflow.com/questions/62629506/dart-vm-options-dsilent-observatory-true

Steps to reproduce:

macos, download android studio, install flutter plugin, new flutter project, run the test with right click, run test (you may have edit the runtest configuration to mark it as flutter test instead of dart test).

As simple as that, the sample project don't run the tests, nor any other project you may have.

franferri · 2020-06-29T17:17:09Z

Tested solution till this get solved for Android Studio.

Go to plugins and remove dart and flutter ones, uninstall completelly
From the following URL's download the previous versions (click load more at the end of the page till the versions show):

Use the following versions (before the Jun25 aberration versions

Dart Plugin (193.6911.31)
Flutter Plugin (46.0.2)

Live the dream

To manually install a plugin from disk go to "Preferences" -> "Plugins" -> Click the little cog icon near the "Installed" tab -> Choose "Install Plugin from Disk..."

helin24 · 2020-06-29T17:18:28Z

@franferri thanks for the detailed report and suggestion - I've reverted this change and this will be released soon. In the meantime, using v46 of the flutter plugin (without changing the dart plugin) should work, and you should also be able to run your tests in debug mode.

Arkangel12 · 2020-06-29T21:40:19Z

Tested solution till this get solved for Android Studio.

Go to plugins and remove dart and flutter ones, uninstall completelly

From the following URL's download the previous versions (click load more at the end of the page till the versions show):

https://plugins.jetbrains.com/plugin/9212-flutter/versions

https://plugins.jetbrains.com/plugin/6351-dart/versions

Use the following versions (before the Jun25 aberration versions

Dart Plugin (193.6911.31)

Flutter Plugin (46.0.2)

Live the dream

To manually install a plugin from disk go to "Preferences" -> "Plugins" -> Click the little cog icon near the "Installed" tab -> Choose "Install Plugin from Disk..."

This steps fail for me in IntelliJ, when i remove Dart and Flutter plugins and try to manually added it sent a message of no compatibility.

when we can have this fix at the IntelliJ marketplace?

franferri · 2020-06-29T22:40:04Z

In the lower part of the screens for the plugins download, there is a button to load more. Load till you find the indicated versions. 3 - 4 times till you find them. The exact versions. Must work as it does in Android studio.

…

On Mon, Jun 29, 2020, 22:40 Argel Bejarano ***@***.***> wrote: *Tested solution till this get solved for Android Studio.* 1. Go to plugins and remove dart and flutter ones, uninstall completelly 2. From the following URL's download the previous versions (click load more at the end of the page till the versions show): - https://plugins.jetbrains.com/plugin/9212-flutter/versions - https://plugins.jetbrains.com/plugin/6351-dart/versions 1. Use the following versions (before the Jun25 aberration versions - Dart Plugin (193.6911.31) - Flutter Plugin (46.0.2) 1. Live the dream To manually install a plugin from disk go to "Preferences" -> "Plugins" -> Click the little cog icon near the "Installed" tab -> Choose "Install Plugin from Disk..." This steps fail for me in IntelliJ, when i remove Dart and Flutter plugins and try to manually added it sent a message of no compatibility. when we can have this fix at the IntelliJ marketplace? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4622 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARPVTEV4C4GSRQ6V2QDVTDRZEC5DANCNFSM4N4UP7BA> .

Arkangel12 · 2020-06-29T22:48:26Z

i did download the exact files it not a file issue, looks like i another problem trying to load a plugin manually in IntelliJ.

This i the message i receive when i try to do it

lukechi1219 · 2020-06-30T00:32:42Z

after install latest Flutter plugin with this fix, Android Studio (IntelliJ) runs flutter test with wrong flag "--start-paused" which would wait for a debugger to connect. Yet in run test mode there won't be a debugger, so it waits until timeout.

flutter test -h
--start-paused Start in a paused mode and wait for a debugger to connect.
You must specify a single test file to run, explicitly.
Instructions for connecting with a debugger are printed to the console once the test has started.

PLEASE rollback asap...

my env info

[√] Flutter (Channel beta, 1.19.0-4.1.pre, on Microsoft Windows [Version 10.0.18363.592], locale en-US)
• Flutter version 1.19.0-4.1.pre at C:\tools\flutter
• Framework revision f994b76974 (3 weeks ago), 2020-06-09 15:53:13 -0700
• Engine revision 9a28c3bcf4
• Dart version 2.9.0 (build 2.9.0-14.1.beta)

[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at C:\Users\LukeChiL5400\AppData\Local\Android\sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: C:\Users\LukeChiL5400\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6514223\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.

[√] Android Studio (version 4.0)
• Android Studio at C:\Users\LukeChiL5400\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6514223
• Flutter plugin version 47.0.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

This reverts commit c241d2e.

safarmer · 2020-08-05T06:09:53Z

Also, there is no option to run tests in debug mode if you are running all tests in a folder. Everything works when I run an individual file.

helin24 · 2020-08-05T16:50:49Z

@safarmer thanks for noting this - going to be tracking this in #4737 if you want to follow updates.

elias8 · 2020-09-17T02:04:10Z

Any updates, please?

helin24 · 2020-09-17T16:26:55Z

@elias8 we made a temporary fix for directory tests in run mode, but debug mode for directory tests will require more work and is not one of our priorities currently. You can upvote or comment on #4742 if this is important to you. (alternatively, if you've seen a regression for a separate problem mentioned here, feel free to post details in a new issue)

Start paused during run mode

f82678e

googlebot added the cla: yes label Jun 12, 2020

jacob314 reviewed Jun 12, 2020

View reviewed changes

helin24 merged commit c241d2e into flutter:master Jun 15, 2020

helin24 deleted the pause branch June 15, 2020 16:23

gmcdowell mentioned this pull request Jun 29, 2020

Observatory Warning & Test Hanging post 47.0.3 install #4667

Closed

helin24 mentioned this pull request Jun 29, 2020

Test execution hanging on 47.0.2 #4666

Closed

helin24 added a commit that referenced this pull request Jun 29, 2020

Revert "Start paused during run mode (#4622)"

9f01465

This reverts commit c241d2e.

helin24 mentioned this pull request Jun 29, 2020

Revert "Start paused during run mode" #4673

Merged

helin24 added a commit that referenced this pull request Jun 29, 2020

Revert "Start paused during run mode (#4622)" (#4673)

9613f52

This reverts commit c241d2e.

franferri mentioned this pull request Jun 29, 2020

[BUG] DART_VM_OPTIONS=-DSILENT_OBSERVATORY=true flutter/flutter#60486

Closed

dvilcode mentioned this pull request Jun 29, 2020

Failed to load test with Flutter test flutter/flutter#60512

Closed

jonasanker mentioned this pull request Jun 29, 2020

Flutter tests do not start flutter/flutter#60519

Closed

stevemessick pushed a commit that referenced this pull request Jun 30, 2020

Revert "Start paused during run mode (#4622)" (#4673)

51965a6

This reverts commit c241d2e.

mprado271 mentioned this pull request Aug 5, 2020

Getting "Warning: You should set SILENT_OBSERVATORY" on 2020.2 build #4732

Open

Start paused during run mode #4622

Start paused during run mode #4622

Uh oh!

Conversation

helin24 commented Jun 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacob314 Jun 12, 2020

Choose a reason for hiding this comment

Uh oh!

helin24 Jun 12, 2020

Choose a reason for hiding this comment

Uh oh!

jacob314 commented Jun 13, 2020

Uh oh!

gmcdowell commented Jun 29, 2020

Uh oh!

blasko commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

franferri commented Jun 29, 2020

Uh oh!

benoitskipr commented Jun 29, 2020

Uh oh!

franferri commented Jun 29, 2020

Uh oh!

franferri commented Jun 29, 2020

Uh oh!

franferri commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

helin24 commented Jun 29, 2020

Uh oh!

Arkangel12 commented Jun 29, 2020

Uh oh!

franferri commented Jun 29, 2020 via email

Uh oh!

Arkangel12 commented Jun 29, 2020

Uh oh!

lukechi1219 commented Jun 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

safarmer commented Aug 5, 2020

Uh oh!

helin24 commented Aug 5, 2020

Uh oh!

elias8 commented Sep 17, 2020

Uh oh!

helin24 commented Sep 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

helin24 commented Jun 12, 2020 •

edited

Loading

blasko commented Jun 29, 2020 •

edited

Loading

franferri commented Jun 29, 2020 •

edited

Loading

lukechi1219 commented Jun 30, 2020 •

edited

Loading