Skip to content

Start paused during run mode #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Start paused during run mode #4622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/io/flutter/sdk/FlutterSdk.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ public FlutterCommand flutterRun(@NotNull PubRoot root,
args.add("--device-id=" + device.deviceId());
}

if (mode == RunMode.DEBUG) {
if (mode == RunMode.DEBUG || mode == RunMode.RUN) {
Copy link
Contributor

@jacob314 jacob314 Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any other mode? also make sure we are not breaking release/profile mode.

Copy link
Member Author

@helin24 helin24 Jun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also RunMode.PROFILE - I guess it would make sense to enable --start-paused for all of the IntelliJ modes (so in that case just remove this conditional)?

I'm having trouble testing flutter profile mode and release mode. Do I need to go through some additional setup steps for this? I se this doc for iOS at least https://flutter.dev/docs/deployment/ios

args.add("--start-paused");
}

Expand Down Expand Up @@ -320,6 +320,8 @@ public FlutterCommand flutterTest(@NotNull PubRoot root, @NotNull VirtualFile fi
if (!myVersion.flutterTestSupportsMachineMode()) {
throw new IllegalStateException("Flutter SDK is too old to debug tests");
}
}
if (mode == RunMode.DEBUG || mode == RunMode.RUN) {
args.add("--start-paused");
}
if (FlutterSettings.getInstance().isVerboseLogging()) {
Expand Down