flutter analyze falsely claims depend_on_referenced_packages violation when using package:collection/collection.dart

[MrCsabaToth]

Part of my CI/CD contains a flutter analyze. I get false depend_on_referenced_packages whenever I use great features of collection.dart.

Relevant sections of pubspec.yaml:

...
environment:
  sdk: ">=2.17.1 <3.0.0"
  flutter: ">=3.0.1"

...
dev_dependencies:
  build_runner: ^2.1.11
  floor_generator: ^1.2.0
  flutter_driver:
    sdk: flutter
  flutter_lints: ^2.0.1
  flutter_test:
    sdk: flutter
  integration_test:
    sdk: flutter
  mockito: ^5.2.0
  mock_data: ^2.0.0

Running:

$ flutter analyze
...
   info • Depend on referenced packages • lib/preferences/palette_spec.dart:3:8 • depend_on_referenced_packages
   info • Depend on referenced packages • lib/ui/parts/circular_menu.dart:5:8 • depend_on_referenced_packages
...

Source code examples:

database_utils.dart (firstWhereOrNull is from collection.dart):

...
import 'package:collection/collection.dart';
...
  Activity? _getActivityById(int id) {
    return activities.firstWhereOrNull((element) => element.id == id);
  }
...
  Record? _getRecordById(int id) {
    return records.firstWhereOrNull((element) => element.id == id);
  }

palette_spec.dart (forEachIndexed is from collection.dart):

...
import 'package:collection/collection.dart';
...
          paletteStr.split(",").forEachIndexed((index, colorStr) {
...
          });

circular_menu.dart:

...
import 'package:vector_math/vector_math.dart' as vector;
...
    final angle = vector.radians(90.0 / (widget.children.length - 1) * index + angleFix);

The problem is to mute this I can add // ignore_for_file: depend_on_referenced_packages to the file but as I understand that would turn of this useful lint for other imports as well. I really like when the linter points out to me when I don't use an import any more.

[MrCsabaToth]

For the package:collection/collection.dart I guess it's the flutter analyze inability to deal with extension methods. The vector one is not extension method though.

[petrnymsa]

This lint is reported if you depend on a transitive dependency. Do you have in your pubspec.yaml defined collection?

dependencies:
   collection: ^1.16.0

I had same issue but after defining dependency, lint issue is gone.

[stuartmorgan-g]

You don't have a dependency on collection, so the lint is correct.

[MrCsabaToth]

Boy I got that wrong! :D

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.