[Impeller] `--enable-impeller-canvas-trace` doesn't work

[gaaclarke]

It has atrophied. That GN flag used to define a c preprocessor macro IMPELLER_TRACE_CANVAS which was added to public_deps. Now the way things are built has made the public_deps on aiks inconsequential.

It would have been helpful for debugging #142001

[gaaclarke]

The following patch will manually enable it:

diff --git a/impeller/aiks/BUILD.gn b/impeller/aiks/BUILD.gn
index 06d643c7b9..13af84ec19 100644
--- a/impeller/aiks/BUILD.gn
+++ b/impeller/aiks/BUILD.gn
@@ -33,6 +33,7 @@ impeller_component("aiks") {
     "picture_recorder.cc",
     "picture_recorder.h",
     "trace_serializer.h",
+    "trace_serializer.cc",
   ]
 
   public_deps = [
@@ -44,7 +45,6 @@ impeller_component("aiks") {
   deps = [ "//flutter/fml" ]
 
   if (impeller_trace_canvas) {
-    sources += [ "trace_serializer.cc" ]
     public_configs = [ ":impeller_canvas_recorder_config" ]
   }
 }
@@ -126,7 +126,6 @@ aiks_unittests_component("aiks_unittests") {
   ]
 
   if (!impeller_trace_canvas) {
-    sources += [ "trace_serializer.cc" ]
     public_configs = [ ":impeller_canvas_recorder_config" ]
   }
 }
diff --git a/impeller/aiks/canvas_recorder.h b/impeller/aiks/canvas_recorder.h
index bbe5832e5b..e00a15dd15 100644
--- a/impeller/aiks/canvas_recorder.h
+++ b/impeller/aiks/canvas_recorder.h
@@ -53,7 +53,6 @@ enum CanvasRecorderOp : uint16_t {
 
 // Canvas recorder should only be used when IMPELLER_TRACE_CANVAS is defined
 // (never in production code).
-#ifdef IMPELLER_TRACE_CANVAS
 /// Static polymorphic replacement for impeller::Canvas that records methods
 /// called on an impeller::Canvas and forwards it to a real instance.
 /// TODO(https://github.com/flutter/flutter/issues/135718): Move this recorder
@@ -324,7 +323,6 @@ class CanvasRecorder {
   Canvas canvas_;
   Serializer serializer_;
 };
-#endif
 
 }  // namespace impeller
 
diff --git a/impeller/aiks/canvas_type.h b/impeller/aiks/canvas_type.h
index c9402c0526..2a6a41341d 100644
--- a/impeller/aiks/canvas_type.h
+++ b/impeller/aiks/canvas_type.h
@@ -14,11 +14,7 @@ namespace impeller {
 /// CanvasType defines what is the concrete type of the Canvas to be used. When
 /// the recorder is enabled it will be swapped out in place of the Canvas at
 /// compile-time.
-#ifdef IMPELLER_TRACE_CANVAS
 using CanvasType = CanvasRecorder<TraceSerializer>;
-#else
-using CanvasType = Canvas;
-#endif
 
 }  // namespace impeller
 

[jonahwilliams]

This code was deleted, closing as obsolete

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.