This flag gates the new "label plugins as dev_dependencies" feature, as well as deprecates two old features:
As of the time of this writing flutter_tools/test/general.shard has 100+ tests that fail with this flag enabled, mostly because they use compute_dev_dependencies transitively, and a fake Pub instance is not hooked up. I have yet to try the other test suites, but likely some fail in commands.shard and integration.shard.
Two options:
- Opt failing tests out explicitly (turn off the feature), turn the feature on, work through failing tests
- Fix failing tests before turning on the feature (opt-them in early)
Will chat with @bkonyi and @andrewkolos to figure out what they prefer.
My intuition is (2) leaves us in a better incremental state. Here is an example: #160258.
TODOs
This flag gates the new "label plugins as dev_dependencies" feature, as well as deprecates two old features:
As of the time of this writing
flutter_tools/test/general.shardhas 100+ tests that fail with this flag enabled, mostly because they usecompute_dev_dependenciestransitively, and a fakePubinstance is not hooked up. I have yet to try the other test suites, but likely some fail incommands.shardandintegration.shard.Two options:
Will chat with @bkonyi and @andrewkolos to figure out what they prefer.
My intuition is (2) leaves us in a better incremental state. Here is an example: #160258.
TODOs
test/commands.shard/permeable/create_test.dart(andtemplates/skeleton)Potentially also a bug in
lib/src/dart/generate_synthetic_packages.dart